fix: add null checks and bounds validation for memory safety#12
Open
gavlooth wants to merge 2 commits intoHigherOrderCO:mainfrom
Open
fix: add null checks and bounds validation for memory safety#12gavlooth wants to merge 2 commits intoHigherOrderCO:mainfrom
gavlooth wants to merge 2 commits intoHigherOrderCO:mainfrom
Conversation
- Add null check after strdup in parse_include - Add bounds check for string parsing (max 4096 codepoints) - Add null check after malloc in table_find 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
|
This probably has performance implications, doing bound validation is expensive. If possible / want us to review and merge, pls do benchmarking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strdupinparse_includeto handle allocation failuremallocintable_findto handle allocation failureTest plan
🤖 Generated with Claude Code